Skip to content

[fm] Temporarily disable fm_analysis background task#10358

Closed
smklein wants to merge 1 commit intomainfrom
fm-disable-analysis
Closed

[fm] Temporarily disable fm_analysis background task#10358
smklein wants to merge 1 commit intomainfrom
fm-disable-analysis

Conversation

@smklein
Copy link
Copy Markdown
Collaborator

@smklein smklein commented May 1, 2026

This PR is coarse-grained, but simple, and provides a solution to #10348 that can be cherry-picked easily.

It should be reverted by #10349

@smklein smklein force-pushed the fm-disable-analysis branch from 182fa27 to 370b4bd Compare May 1, 2026 19:44
@smklein smklein marked this pull request as ready for review May 1, 2026 19:45
@AlejandroME AlejandroME added this to the 19 milestone May 1, 2026
Copy link
Copy Markdown
Member

@hawkw hawkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes me feel sad and gross but i agree that it is the right thing to do temporarily

@smklein
Copy link
Copy Markdown
Collaborator Author

smklein commented May 1, 2026

this makes me feel sad and gross but i agree that it is the right thing to do temporarily

If you feel strongly #10360 is yet again one more way to fix this (that should be safe to cherry-pick).

@smklein
Copy link
Copy Markdown
Collaborator Author

smklein commented May 4, 2026

Closing in lieu of #10360

@smklein smklein closed this May 4, 2026
@smklein smklein deleted the fm-disable-analysis branch May 4, 2026 17:03
smklein added a commit that referenced this pull request May 4, 2026
Alternative to #10358 

Adds an opt-in `fm.analysis_enabled` flag which defaults to false.

Yet another possible fix for
#10348

To re-enable: toggle `default_fm_analysis_enabled` to return `true`
instead of `false`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants