omdb: add marked-as-seen to omdb db ereport list#10364
Merged
Merged
Conversation
This PR adds a column to `omdb db ereport list` to indicate whether or not an ereport has been marked as "seen" by sitrep rendezvous. It also adds a CLI argument to filter ereports based on whether or not they have been marked.
hawkw
added
Debugging
smklein
approved these changes
May 4, 2026
Comment on lines
+93
to
+99
| /// Note that ereports which have not been marked in the database *may* | ||
| /// still have been included in a sitrep. Marking of ereport database | ||
| /// records occurs in the background, and may not be up to date with the | ||
| /// latest sitrep. If an ereport has been marked as seen, it has | ||
| /// *definitely* been included in a committed sitrep, but if an ereport | ||
| /// has not been marked, it *may or may not* have been included in a | ||
| /// committed sitrep. |
Collaborator
There was a problem hiding this comment.
Thanks for including this note; it's true, and also an important caveat for anyone using this
| #[derive(Tabled)] | ||
| #[tabled(rename_all = "SCREAMING_SNAKE_CASE")] | ||
| struct EreportRowWithMark<'report> { | ||
| mark: &'static str, |
Collaborator
There was a problem hiding this comment.
nit: This could maybe be an enum with a "to string" impl instead of an arbitrary static str, right? but I don't care too much
Member
Author
There was a problem hiding this comment.
I went back and forth on this because I also didn't love the idea of an enum with a fmt::Display implementation that was an empty string. The reason I had left a similar suggestion on your PR was because we also had logic that was checking for a specific string. I think we could make this an enum but i don't think it's worth it in this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a column to
omdb db ereport listto indicate whether ornot an ereport has been marked as "seen" by sitrep rendezvous. It also
adds a CLI argument to filter ereports based on whether or not they have
been marked. This information is already included in the
omdb db ereport infooutput, but I felt like it was worth adding tothe list command as well.