Move Gateway configuration out of Sled Agent, into RSS

[smklein]

Fixes #1527

[smklein]

To elaborate a bit on this comment, I believe this PR accomplishes #1527 by moving the gateway information from:

"must be known at package time" (bundled with Sled Agent)
to
"must be known at RSS time" (set once when configuring Sled Agent)

It probably makes sense to migrate this further, to:
"must be known when launching Nexus (and can be modified on a live system)"

[bnaecker]

Fair enough, I didn’t mean to imply we’d explicitly provide the switch this value, only that it might be learned by the switch through a discovery protocol. ARP is what I had in mind though that might not be right.

…

On 1 Aug 2022, at 17:08, Robert Mustacchi ***@***.***> wrote:  @rmustacc commented on this pull request. In smf/sled-agent/config-rss.toml: > @@ -11,6 +11,22 @@ rack_subnet = "fd00:1122:3344:0100::" # For values less than 2, no rack secret will be generated. rack_secret_threshold = 1 +[gateway] + +# IP address of Internet gateway +# +# NOTE: In the lab, use "172.20.15.225" +# address = "192.168.1.1" + +# MAC address of the internet gateway in the local network, i.e., of the above +# IP address. +# +# NOTE: This is currently configured for the lab. Developers should override +# this with whatever value they wish to provide inbound connectivity to guests +# in their local network, using the current workaround methods in OPTE. See +# how-to-run.adoc for details on how to determine the value for your network. +mac = "00:0d:b9:54:fe:e4" The switch itself may not even know the MAC address. For IP level connectivity we will never be asking customers about MAC addresses. The only exception may be for some particular routing config or allow/deny list / lldp. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because your review was requested.