-
Notifications
You must be signed in to change notification settings - Fork 62
pass initial TLS certificates into RSS #3073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…must use a hostname for TLS validation to work
luqmana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few minor comments but looks good thanks. i would update the how-to-run doc at least to make mention of this
|
Thanks for the review! I think I addressed the feedback in 57b9eec. |
luqmana
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Right now, RSS always provides an empty list of initial TLS certificates (for the external API) to Nexus during rack initialization. On a real system, the user will provide the initial certificate over the technician port during initial setup (see RFDs 57, 323). This means Wicket will get them, and it will need to provide them to RSS. This PR adds these as a parameter to RSS's rack-initialize endpoint.
This affects different environments:
Fixes #1528.
This also addresses one of the two remaining items in #1529. The other one is notifying Nexus instances when one of them receives a certificate update. In an upcoming PR, I intend to instead have Nexus instances have a background task to monitor the list of certs.