[nexus] remove views::SledProvisionState::Unknown #4608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.5
11 tasks
ahl
approved these changes
Dec 4, 2023
Contributor
ahl
left a comment
ahl
left a comment
There was a problem hiding this comment.
Thanks! FWIW while it's true that progenitor doesn't do anything special with regard to unknown variants, it also doesn't choke on them! I think we might want the json schema to reflect the unknown/catchall nature of a variant like this if we were to do this in the future.
sunshowers
deleted the
sunshowers/spr/nexus-remove-viewssledprovisionstateunknown
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't quite work as expected:
SledProvisionStateis specified, we immediately produce an error as soon as we enter the HTTP entrypoint. There's no functional difference between that and producing an error at deserialization time.#[serde(other)]so the unknown type doesn't work.