Generate "crdb-base" directory in target, not temporary directory #563
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new behavior abides by the rules for generating output from a build script, by using the
OUT_DIRpath available at compile-time.To ensure that the
OUT_DIRpath is available to the build script and invocations oftest_setup_database, the crates are organized as follows:test-utils, the top-level crate, contains functionality for both populating + copying from a seed directory. This is made available to both the build script (innexus/test-utils) and any tests (innexus) that want to calltest_setup_database. Calling thetest-utilsversion oftest_setup_databasenow explicitly requires providing a path to the seed directory.nexus/test-utilsdefines anOUT_DIR, and creates thecrdb-basedirectory there. It additionally provides another implementation oftest_setup_database, which also embeds the path to thecrdb-basedirectory.test_setup_databasefromnexus/test-utils, which embeds the path tocrdb-basecreated from the build script.Fixes #548