Skip to content

Make use of the #derive(JsonSchema) addition to progenitor #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

Make use of the #derive(JsonSchema) addition to progenitor #580

wants to merge 7 commits into from

Conversation

@smklein
Copy link
Collaborator

@smklein smklein commented Jan 7, 2022 •
edited
Loading

smklein
smklein commented Jan 7, 2022
View reviewed changes
Cargo.toml Outdated
Comment on lines 60 to 63
[patch."https://github.com/oxidecomputer/progenitor"]
progenitor = { path = "../progenitor/progenitor" }
[patch."https://github.com/oxidecomputer/crucible"]
crucible-agent-client = { path = "../crucible/agent-client" }
Copy link
Collaborator Author

@smklein smklein Jan 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These obviously need to be removed before merging.

@smklein smklein mentioned this pull request Jan 7, 2022
Merged
ahl
ahl reviewed Jan 7, 2022
View reviewed changes
oximeter/producer/src/lib.rs Outdated
.await
.map_err(|msg| Error::RegistrationError(msg.to_string()))
.map_err(|msg| Error::RegistrationError(msg.to_string()))?;
Ok(())
Copy link
Contributor

@ahl ahl Jan 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, this is an unrelated progenitor update that we'll catch on the next dependabot sync

smklein and others added 5 commits January 14, 2022 17:18
@smklein @david-crespo
Add Rust Cache Action to Github Actions (#498)
6d02abd 
Co-authored-by: David Crespo <david.crespo@oxidecomputer.com>
@andrewjstone
Introduce thing-flinger (#534)
2e5c819 
`thing-flinger` is a remote deployment system for installing Omicron. It's
intended to be used to simplify and shorten the testing cycle.

More information is found in the [documentation](package/src/README.adoc).
@ahl
update dropshot and progenitor (#602)
2a760e3
@ahl
Merge branch 'main' of github.com:oxidecomputer/omicron into use-json…
4768485 
…-schema
@ahl
update to use the new progenitor interface
1beee37
@ahl ahl changed the base branch from regions to main January 18, 2022 18:49
@ahl ahl changed the base branch from main to regions January 18, 2022 18:51
@ahl ahl mentioned this pull request Jan 18, 2022
Merged
@smklein
Copy link
Collaborator Author

smklein commented Jan 21, 2022

I went ahead and merged this into #511 , closing.

@smklein smklein closed this Jan 21, 2022
@smklein smklein deleted the use-json-schema branch January 21, 2022 16:06
@ahl
Copy link
Contributor

ahl commented Jan 21, 2022

@smklein did this make it in? 1beee37#diff-d38884f7391ae50f795707dbb281656e8afe38ea3ecac15a6ee80d52724017c0

@smklein
Copy link
Collaborator Author

smklein commented Jan 21, 2022

Admittedly, no, it did not - I think the JsonSchema I actually need is the one for the Crucible Agent Client, which I believe already merged in Crucible: https://github.com/oxidecomputer/crucible/blob/main/agent-client/src/lib.rs#L7

@ahl
Copy link
Contributor

ahl commented Jan 21, 2022

Nice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahl ahl ahl left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@smklein @ahl @andrewjstone