[2/n] [update-engine] add ( to the beginning of step indexes in the line displayer
#6447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
sunshowers
changed the base branch from
main
to
sunshowers/spr/main.update-engine-add-to-the-beginning-of-step-indexes-in-the-line-displayer
sunshowers
changed the base branch from
sunshowers/spr/main.update-engine-add-to-the-beginning-of-step-indexes-in-the-line-displayer
to
main
Created using spr 1.3.6-beta.1
sunshowers
changed the title
( to the beginning of step indexes in the line displayer( to the beginning of step indexes in the line displayer
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
sunshowers
deleted the
sunshowers/spr/update-engine-add-to-the-beginning-of-step-indexes-in-the-line-displayer
branch
hawkw
pushed a commit
that referenced
this pull request
Aug 31, 2024
… line displayer (#6447) This was reported by @wfchandler -- not sure why I missed these originally. Also move the step index display logic out into its own displayer -- I need this (including the padded logic) in a couple of spots. This can be landed separately from #6444. Some example output from `cargo run --example update-engine-basic -- -s line`: ``` [00:00:00] Running (1/7) Downloading component: https://www.example.org [00:00:00] Progress (1/7) Downloading component: https://www.example.org: 12.50% ( 131072/1048576 bytes) after 101.22ms [00:00:00] Progress (1/7) Downloading component: https://www.example.org: 25.00% ( 262144/1048576 bytes) after 201.49ms [00:00:00] Retry (1/7) Downloading component: https://www.example.org: after 302.77ms (at attempt 1) with message: Simulated failure at 25% [00:00:00] Progress (1/7) Downloading component: https://www.example.org: 0.00% ( 0/1048576 bytes) after 101.37ms [00:00:00] Progress (1/7) Downloading component: https://www.example.org: 10.00% ( 104857/1048576 bytes) after 201.61ms [00:00:00] Progress (1/7) Downloading component: https://www.example.org: 20.00% ( 209715/1048576 bytes) after 302.86ms [00:00:00] Progress (1/7) Downloading component: https://www.example.org: 30.00% ( 314572/1048576 bytes) after 404.14ms ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was reported by @wfchandler -- not sure why I missed these originally.
Also move the step index display logic out into its own displayer -- I need
this (including the padded logic) in a couple of spots.
This can be landed separately from #6444.
Some example output: