Replace a custom hyper test server with httpmock #6576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnaecker
reviewed
Sep 13, 2024
Collaborator
bnaecker
left a comment
bnaecker
left a comment
There was a problem hiding this comment.
That's awesome, thanks!
ahl
commented
Sep 13, 2024
| highway = "1.2.0" | ||
| hkdf = "0.12.4" | ||
| http = "0.2.12" | ||
| httpmock = "0.8.0-alpha.1" |
Contributor
Author
There was a problem hiding this comment.
I chose this version to get familiarity for our use of this crate in oxide.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my misguided effort to migrate us to hyper v1, I stumbled onto a custom hyper server that we use for testing the oximeter consumer. With hyper v1, this code breaks, so we need to do something. My observation is that hyper v1 has made this sort of small server a bigger pain in the neck to write. So if we're going to need to do work, my suggestion is to do less work.
The
httpmockcrate is pretty ideal for this use case. While we already havehttptestin omicron, it doesn't do quite as good of a job here (in particular you say "this mock should be hit N times" whereas this use case wants to say "how many times was this mock hit?"). While I'm a bit reluctant to expand our dependency graph with a second http mocking crate... it's a bit late in the day to fret about the expansiveness of the dependency graph!