Only perform region replacement for r/w regions#7243
Merged
jmpesp merged 2 commits intooxidecomputer:mainfrom Dec 18, 2024
Merged
Only perform region replacement for r/w regions#7243jmpesp merged 2 commits intooxidecomputer:mainfrom
jmpesp merged 2 commits intooxidecomputer:mainfrom
Conversation
Region replacement does not work for read-only regions (there is a check in the region_replacement_start saga that bails out if the supplied region is read-only) - this is tracked by oxidecomputer#6172. The current plan to make read-only region replacement work is to use the same machinery as region snapshot replacements (as they're both read-only), so this commit changes the current query that finds expunged regions to replace to only return read/write regions. This can be changed back in the future if the plan for oxidecomputer#6172 changes.
leftwo
approved these changes
Dec 12, 2024
Contributor
leftwo
left a comment
leftwo
left a comment
There was a problem hiding this comment.
Yeah, but we should wait till 12 rolls out before merging to main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Region replacement does not work for read-only regions (there is a check in the region_replacement_start saga that bails out if the supplied region is read-only) - this is tracked by #6172. The current plan to make read-only region replacement work is to use the same machinery as region snapshot replacements (as they're both read-only), so this commit changes the current query that finds expunged regions to replace to only return read/write regions. This can be changed back in the future if the plan for #6172 changes.