Skip to content

Conversation

@smklein
Copy link
Collaborator

@smklein smklein commented Mar 22, 2022

Ports https://github.com/davepacheco/toy-dns into Omicron as internal-dns:

@smklein smklein changed the title Service discovery [internal-dns] First pass at integrating service discovery codebase Mar 22, 2022
@davepacheco
Copy link
Collaborator

Thanks for doing this! CC @rcgoodfellow.

I think it's worth keeping the CLI tool. Maybe make it a binary in internal-dns-client?

@smklein
Copy link
Collaborator Author

smklein commented Mar 24, 2022

I think it's worth keeping the CLI tool. Maybe make it a binary in internal-dns-client?

Done, added as dnsadm

Copy link
Collaborator

@davepacheco davepacheco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't really reviewed most of the code here. But at this point I think the risk is low and urgency is important -- we should land this so we can make forward progress on the things that need it.

@rcgoodfellow
Copy link
Contributor

The prototype also as a testing workflow that runs the automated tests if you want to pick that up.

Copy link
Contributor

@rcgoodfellow rcgoodfellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smklein
Copy link
Collaborator Author

smklein commented Mar 25, 2022

The prototype also as a testing workflow that runs the automated tests if you want to pick that up.

I did port the tests over, but Omicron has its own automation that should be running them: https://github.com/oxidecomputer/omicron/blob/main/.github/workflows/rust.yml

@smklein smklein merged commit 75e1bf8 into main Mar 25, 2022
@smklein smklein deleted the service-discovery branch March 25, 2022 15:23
smklein added a commit that referenced this pull request Apr 25, 2022
Builds on #800 , actually launching the internal DNS subsystem as a Zone.

Part of #718
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants