Skip to content

Conversation

@smklein
Copy link
Collaborator

@smklein smklein commented Mar 24, 2022

Builds on #800 , actually launching the internal DNS subsystem as a Zone.

Part of #718

@@ -0,0 +1,22 @@
[dropshot]
bind_address = "[fd00:1234::4]:5353"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These addresses are totally made-up -- I have some follow-up work to incorporate the subnets of the physical network described in RFD 63 into this repo.

Comment on lines 42 to 44
[[request.service]]
name = "internal-dns"
addresses = [ "[fd00:1234::4]:5353" ]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, with this addition, the RSS spins up an "internal-dns" zone on this Sled.

I confirmed that this service is running and accessible by using:

cargo run --bin dnsadm -- -a [fd00:1234::4] list-records

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

@@ -0,0 +1,36 @@
<?xml version="1.0"?>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this is following a pattern of other services. Has @jclulow taken a look at this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a variety of XML files under smf in Omicron, if you wanna compare:

./nexus/manifest.xml
./oximeter/manifest.xml
./cockroachdb/manifest.xml
./clickhouse/manifest.xml
./sled-agent/manifest.xml

Comment on lines 42 to 44
[[request.service]]
name = "internal-dns"
addresses = [ "[fd00:1234::4]:5353" ]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

Base automatically changed from service-discovery to main March 25, 2022 15:23
Copy link
Contributor

@rcgoodfellow rcgoodfellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe all the comments I made have been addressed.

Thanks for taking this from prototype to being a part of Omicron!

@smklein smklein merged commit 8cc6e1f into main Apr 25, 2022
@smklein smklein deleted the service-discovery-in-a-zone branch April 25, 2022 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants