-
Notifications
You must be signed in to change notification settings - Fork 62
[internal-dns] Shove service discovery into a zone #807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
79fb8f3
Add internal-dns service
smklein 1a15d6c
fmt
smklein 4faef91
wip
smklein 5351d85
Merge branch 'main' into service-discovery
smklein 8f373bd
Added dnsadm
smklein 62c5778
Merge branch 'service-discovery' into service-discovery-in-a-zone
smklein a575e42
Add internal-dns SMF config, start it by RSS
smklein 39758c0
Merge branch 'main' into service-discovery
smklein f814759
Merge branch 'service-discovery' into service-discovery-in-a-zone
smklein 4ca5c80
Merge branch 'main' into service-discovery
smklein 789e274
Merge branch 'service-discovery' into service-discovery-in-a-zone
smklein a52e4b6
review feedback
smklein 73c0008
Merge branch 'main' into service-discovery-in-a-zone
smklein a9840d6
Patch addresses
smklein 437d699
Updated cfg path
smklein 4dc45ff
patch addresses
smklein 77b8840
Merge branch 'main' into service-discovery-in-a-zone
smklein c1e2180
updated storage path
smklein 9f7f55b
Bunyan formatted
smklein File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| [dropshot] | ||
| bind_address = "[fd00:1122:3344:1::9]:5353" | ||
| request_body_max_bytes = 1048576 | ||
|
|
||
| [dns] | ||
| bind_address = "[fd00:1122:3344:1::9]:53" | ||
|
|
||
| [log] | ||
| # Show log messages of this level and more severe | ||
| level = "info" | ||
| mode = "file" | ||
| path = "/var/oxide/internal-dns.log" | ||
| if_exists = "append" | ||
|
|
||
| [data] | ||
| nmax_messages = 16 | ||
| storage_path = "/var/oxide/dns" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| <?xml version="1.0"?> | ||
| <!DOCTYPE service_bundle SYSTEM "/usr/share/lib/xml/dtd/service_bundle.dtd.1"> | ||
|
|
||
| <service_bundle type='manifest' name='internal-dns'> | ||
|
|
||
| <service name='system/illumos/internal-dns' type='service' version='1'> | ||
| <create_default_instance enabled='false' /> | ||
| <single_instance /> | ||
|
|
||
| <dependency name='multi_user' grouping='require_all' restart_on='none' | ||
| type='service'> | ||
| <service_fmri value='svc:/milestone/multi-user:default' /> | ||
| </dependency> | ||
|
|
||
| <exec_method type='method' name='start' | ||
| exec='ctrun -l child -o noorphan,regent /opt/oxide/internal-dns/bin/dns-server --config-file /var/svc/manifest/site/internal-dns/config.toml &' | ||
| timeout_seconds='0' /> | ||
| <exec_method type='method' name='stop' exec=':kill' timeout_seconds='0' /> | ||
|
|
||
| <property_group name='startd' type='framework'> | ||
| <propval name='duration' type='astring' value='contract' /> | ||
| </property_group> | ||
|
|
||
| <stability value='Unstable' /> | ||
|
|
||
| <template> | ||
| <common_name> | ||
| <loctext xml:lang='C'>Internal DNS</loctext> | ||
| </common_name> | ||
| <description> | ||
| <loctext xml:lang='C'>Oxide's Internal DNS Service</loctext> | ||
| </description> | ||
| </template> | ||
| </service> | ||
|
|
||
| </service_bundle> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this is following a pattern of other services. Has @jclulow taken a look at this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a variety of XML files under
smfin Omicron, if you wanna compare: