bump to v15; API version to planned release date#8077
Merged
Conversation
davepacheco
approved these changes
May 1, 2025
Collaborator
davepacheco
left a comment
davepacheco
left a comment
There was a problem hiding this comment.
This looks fine to me but I don't know if there are any constraints or dependencies around bumping BASE_VERSION.
| use openapiv3::OpenAPI; | ||
|
|
||
| pub const API_VERSION: &str = "20250409.0.0"; | ||
| pub const API_VERSION: &str = "20250604.0.0"; |
Collaborator
There was a problem hiding this comment.
It looks to me like this constant only exists to be checked against what's in the OpenAPI document in the test in this file. Is that right?
Contributor
Author
There was a problem hiding this comment.
I don't really have context, I've just been blindly bumping it, but yes?
Contributor
Author
Not yet. It's only used within releng to set the system version in the TUF repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to the usual bump, I adjusted the API description references so that rustfmt would successfully run (it was interfering with the 80-column limit), and wrote a test to enforce sorting of the API descriptions.