Support dual-stack NICs in the public API #9508
Conversation
bnaecker
force-pushed
the
external-api-for-dual-stack-instances
branch
8 times, most recently
from
cd0803a to
b276b93
Compare
|
I'm working on the NIC-update APIs, but need to get #9542 to make that work. That'll let us update a NIC's transit IPs on a per-stack basis, rather than some RMW with the DB. |
bnaecker
force-pushed
the
external-api-for-dual-stack-instances
branch
from
b276b93 to
bc3f12c
Compare
bnaecker
force-pushed
the
external-api-for-dual-stack-instances
branch
3 times, most recently
from
2df5da9 to
a54fdb0
Compare
- Move IP traits and config types to common modules so they can be used in the public API - Add private IP stack types to external API, used when fetching NICs - Add new `IpConfig` type to the parameters for creating NICs. This gives a more flexible scheme for selecting an IP address automatically or explicitly, and independently for each IP stack. - Add a new version of the external API for the new types, and implement conversions from the previous - Ensure external IPs are allocated for NICs with a corresponding private IP stack, checking at both IP creation and attachment. - Check that candidate secondary NICs have an IP stack for every external IP when setting them to a new primary
bnaecker
force-pushed
the
external-api-for-dual-stack-instances
branch
from
a54fdb0 to
342aee5
Compare
|
There are a few tests that will fail until I rebase on @zeeshanlakhani's changes in #9452 once that merges. This is ready for a review now though. |
bnaecker
requested review from
FelixMcFelix,
rcgoodfellow and
zeeshanlakhani
rcgoodfellow
left a comment
rcgoodfellow
left a comment
There was a problem hiding this comment.
Thanks for pulling all this together @bnaecker! Lots of details to line up and some hairy database work.
I've been rebasing my ipv6/all-the-things onto this branch and things are working e2e for IPv6 comms with probes.
A few minor comments/questions follow.
|
Alright, I've integrated this with the updated handling of default pools, and have now gotten all the tests to pass and my own TODOs addressed. @rcgoodfellow thanks for your feedback, I'd love another pass when you get a minute. |
|
Still need to resolve another conflict with main. |
rcgoodfellow
left a comment
rcgoodfellow
left a comment
There was a problem hiding this comment.
LGTM. All my comments have been addressed.
|
The multicast failure looks like a flake. There's a timeout we're exceeding, but it passes locally quite quickly. I'll fixup the API check test now. |
IpConfigtype to the parameters for creating NICs. This gives a more flexible scheme for selecting an IP address automatically or explicitly, and independently for each IP stack.