Adjust RouteCache to mitigate contention#998
Open
FelixMcFelix wants to merge 4 commits into
Open
Conversation
Let's introduce contention to actually measure the impact of the next few changes...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows up on the steps outlined in #997. The main changes are to increase the table size, and to minimise the amount of time holding the write lock on a miss by fetching a new route before taking the lock. This includes refusing to attempt an insert on a failed lookup in a full table.
One of the steps outlined in the issue, not evicting present entries, was already implemented.
Closes #997.