Conversation
89cc521 to
deecf05
Compare
Implemented the service controller to handle `LoadBalancer` services using the cloud controller manager. Oxide doesn't have a load balancer service yet so this controller implements the following logic. - Allocate a floating IP and attach it to the first Kubernetes node ordered by name. - Ensure the node's internal IP addresses are listed in the load balancer status. This allows the proper firewall rules (i.e., `nftables`) to be created on the node to allow the traffic. This is needed since Oxide floating IPs are transparent to the instance so traffic enters the instance using the instance's internal IP address as the destination, not the floating IP address. Closes SSE-53. Amp-Thread: https://ampcode.com/threads/T-019cf987-216f-703f-acbd-1d406d081491 Amp-Thread: https://ampcode.com/threads/T-019cfea7-0a17-730f-8b66-aa65b8f7273e
deecf05 to
5059c3b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: service controller
Implemented the service controller to handle
LoadBalancerservicesusing the cloud controller manager. Oxide doesn't have a load balancer
service yet so this controller implements the following logic.
ordered by name.
balancer status. This allows the proper firewall rules (i.e.,
nftables) to be created on the node to allow the traffic. This isneeded since Oxide floating IPs are transparent to the instance so
traffic enters the instance using the instance's internal IP address as
the destination, not the floating IP address.
Closes SSE-53.
Amp-Thread: https://ampcode.com/threads/T-019cf987-216f-703f-acbd-1d406d081491
Amp-Thread: https://ampcode.com/threads/T-019cfea7-0a17-730f-8b66-aa65b8f7273e