feat(map_type): support custom map types.#1011
Merged
ahl merged 2 commits intooxidecomputer:mainfrom Dec 24, 2024
Merged
Conversation
ahl
approved these changes
Dec 23, 2024
Collaborator
ahl
left a comment
ahl
left a comment
There was a problem hiding this comment.
Looks good. Thanks for this. Let's get CI sorted out
JosiahBull
force-pushed
the
jo/support-custom-map-types
branch
from
fdc7f02 to
ac0212a
Compare
JosiahBull
force-pushed
the
jo/support-custom-map-types
branch
from
ac0212a to
187d12a
Compare
Contributor
Author
|
@ahl Resolved CI issues. 😄 |
Collaborator
|
Thanks for the contribution! |
ysndr
added a commit
to flox/flox
that referenced
this pull request
May 26, 2025
ysndr
added a commit
to flox/flox
that referenced
this pull request
May 26, 2025
ysndr
added a commit
to flox/flox
that referenced
this pull request
May 27, 2025
ysndr
added a commit
to flox/flox
that referenced
this pull request
May 29, 2025
github-merge-queue bot
pushed a commit
to flox/flox
that referenced
this pull request
May 30, 2025
Our version of progenitor was stuck on `0.6.0` since we specified `0.6` in our Cargo.toml, and cargo/dependabot won't bump potentially breaking changes, i.e. major version bumps or minor version bumps iff major == 0. While this alos required bumping reqwest, at least statically, no further breakages were discovered by this. Notable changes: - oxidecomputer/progenitor#1120 - oxidecomputer/progenitor#1017 - oxidecomputer/progenitor#1011 - oxidecomputer/progenitor#949 - oxidecomputer/typify#584
bryanhonof
pushed a commit
to flox/flox
that referenced
this pull request
Jul 9, 2025
abus-sh
pushed a commit
to abus-sh/progenitor
that referenced
this pull request
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #985
@ahl Let me know what more you'd like to see here, kept the initial impl pretty bare bones as last time.