Skip to content

local disk metrics #1095

@iximeow

Description

@iximeow

in looking at #1073 I noticed two things:

While we could pretty easily turn on local disk metrics on a whim (we should just move the block_dev.set_metric_consumer line), doing so would add the same kind of problem as #1003 solved: one Arc whose refcount is contended over by basically every (non-vCPU) thread in Propolis. so we really should not do that without fixing the issue and measuring relative impact.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request.local storageRelating to the local storage projectrelease notesreminder to include this in the release notes

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions