-
Notifications
You must be signed in to change notification settings - Fork 34
local disk metrics #1095
Copy link
Copy link
Closed
Labels
enhancementNew feature or request.New feature or request.local storageRelating to the local storage projectRelating to the local storage projectrelease notesreminder to include this in the release notesreminder to include this in the release notes
Metadata
Metadata
Assignees
Labels
enhancementNew feature or request.New feature or request.local storageRelating to the local storage projectRelating to the local storage projectrelease notesreminder to include this in the release notesreminder to include this in the release notes
Type
Fields
Give feedbackNo fields configured for issues without a type.
in looking at #1073 I noticed two things:
While we could pretty easily turn on local disk metrics on a whim (we should just move the
block_dev.set_metric_consumerline), doing so would add the same kind of problem as #1003 solved: one Arc whose refcount is contended over by basically every (non-vCPU) thread in Propolis. so we really should not do that without fixing the issue and measuring relative impact.