Conversation
Pick up the following Crucible PRs: - Add VolumeInfo (1928) - Remove bonus Volume layer (1927) - Add session and client id to panic messages (#1926) - [crucible-agent-types] migrate to RFD 619 pattern (1899) - Background read-only region creation (1919) - [crucible-downstairs-repair] switch to RFD 619 pattern (1901) - [crucible-pantry] switch to RFD 619 pattern (1900) - Use separate in-memory types (1913) - Remove old field from dtrace action script (1917) Additionally, bump the server API and change the `disk_volume_status` endpoint to return the new VolumeInfo struct.
iximeow
approved these changes
May 4, 2026
Member
iximeow
left a comment
iximeow
left a comment
There was a problem hiding this comment.
just the one comment because I really Do Not Know What That Means, sorry for the slow turnaround here 🙏
|
|
||
| /// Gets the status of a Crucible volume backing a disk | ||
| #[endpoint { | ||
| operation_id = "disk_volume_status", |
Member
There was a problem hiding this comment.
oh I see, disk_volume_status is the automatically-chosen Id for async fn disk_volume_status below, and by setting it explicitly like this we're telling Dropshot that this is a different version of that API rather than a new disk_volume_status_v1? I'm not sure if I'm missing a detail to that, but if so then carry on 🫡
Contributor
Author
There was a problem hiding this comment.
no you're right - this is done to maintain the operation ID for older versions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pick up the following Crucible PRs:
Additionally, bump the server API and change the
disk_volume_statusendpoint to return the new VolumeInfo struct.