Ndh/spd proxy fixes#495
Merged
Merged
Conversation
nathanaelhuffman
force-pushed
the
ndh/spd-proxy-fixes
branch
from
510d731 to
637ca79
Compare
Collaborator
Author
|
With changes at this point, there's at least one bug here still, this looks like it might be around playback sclk fedges?: |
nathanaelhuffman
force-pushed
the
ndh/spd-proxy-fixes
branch
3 times, most recently
from
997eea5 to
17a8150
Compare
nathanaelhuffman
force-pushed
the
ndh/spd-proxy-fixes
branch
from
17a8150 to
98ae078
Compare
The REDGE-exit branch (cpu_scl_in='1' catch-up) set dimm_sda_oe one registered cycle after the rising edge, while the playback SCL was still high -- producing a spurious start or stop condition on the DIMM bus. The FEDGE path already handles catch-up exit correctly, so just remove the REDGE branch and let playback_bits increment cleanly.
nathanaelhuffman
force-pushed
the
ndh/spd-proxy-fixes
branch
from
98ae078 to
9ed5572
Compare
nathanaelhuffman
force-pushed
the
ndh/spd-proxy-fixes
branch
from
9ed5572 to
2319f5c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A number of bugs discovered by analysis, and one found through testing after the other 4 were fixed.
I've got 200 A2 -> A0 sequences on my cosmo with 1.5TB of RAM installed with no missing DIMMs reported, so I think this is good to go.
Fixes #496
Fixes #497
Fixes #498
Fixes #499
And fixes the bug shown in an image below, which is difficult to reproduce in simulation at the current simulation bit rates, but was a result of transitioning out of
ENSURE_PLAYBACK_HOLDif the SP5 SCL was still high.