Skip to content

fpga-releaser: fix --skip-gh and inverted needs_gh check #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nathanaelhuffman merged 1 commit into from
May 18, 2026
Merged

fpga-releaser: fix --skip-gh and inverted needs_gh check #502

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions tools/fpga_releaser/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,14 @@ def main():
if args.zip:
project_info.local = True

# Only require a GitHub token when we actually need to talk to GitHub
needs_gh = not (args.skip_gh or args.zip is None)
if args.skip_gh and args.zip is None:
print("--skip-gh requires --zip or --local to supply a build archive")
sys.exit(1)

# Only require a GitHub token when we actually need to talk to GitHub.
# With --skip-gh we have a local archive (enforced above) and won't push a
# release, so the API client stays unused.
needs_gh = not args.skip_gh
api = None
if needs_gh:
if args.token is not None:
Expand Down
Loading