Add support for group membership replace ops#61
Merged
papertigers merged 6 commits intomainfrom Aug 22, 2025
Merged
Conversation
Created using jj-spr 1.3.6-beta.1 [skip ci]
Created using jj-spr 1.3.6-beta.1
Created using jj-spr 1.3.6-beta.1
Created using jj-spr 1.3.6-beta.1 [skip ci]
papertigers
changed the base branch from
spr/papertigers/main.add-support-for-group-membership-replace-ops
to
main
jmpesp
approved these changes
Aug 22, 2025
core/src/patch.rs
Outdated
| group.resource.members = | ||
| (!new_members.is_empty()).then_some(new_members); | ||
| } | ||
| // Treat this as a display name change |
Collaborator
There was a problem hiding this comment.
The None block here doesn't exactly assume this is a display name change due to the deserialization checking for the display_name field - maybe take this out and link to the spec's bit about this?
If the "path" parameter is omitted, the target is assumed to be
the resource itself. In this case, the "value" attribute SHALL
contain a list of one or more attributes that are to be replaced.
papertigers
deleted the
spr/papertigers/add-support-for-group-membership-replace-ops
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for PATCHing a group with a replace op of its members.