[2/n] add tests for duplicate control plane zones and artifacts#18
Merged
sunshowers merged 5 commits intomainfrom Mar 25, 2025
Conversation
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
sunshowers
changed the title
iliana
approved these changes
Mar 25, 2025
Created using spr 1.3.6-beta.1
sunshowers
changed the base branch from
sunshowers/spr/main.2n-add-test-which-ensures-duplicate-control-plane-zones-are-detected
to
main
sunshowers
deleted the
sunshowers/spr/2n-add-test-which-ensures-duplicate-control-plane-zones-are-detected
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already have code which ensures that duplicate zones and artifacts are detected. Add tests to exercise these code paths (we're going to hoist them to a higher level in a subsequent commit).
While writing this code, I realized that we don't exit with code 0 when encountering duplicate artifacts. That's not good. I'll fix it in a subsequent commit.