Merged
Conversation
- Remove deprecated actions-rs/toolchain
- Remove deprecated actions-rs/cargo
- Add concurrency cancel keys
- pin `actions/checkout`
- Standardize 'run' line format
- Only run on main/PR pushes
- Remove unnecessary `permissions: {contents: read}` (this is default
for push/pull request events)
- switch rust-toolchain.toml to pin to explicit rust version instead of
stable.
notpeter
commented
Mar 13, 2026
| - uses: actions-rs/cargo@844f36862e911db73fe0815f00a4a2602c279505 # v1 | ||
| with: | ||
| command: build | ||
| args: --release --all-features |
Contributor
Author
There was a problem hiding this comment.
What's the purpose of running build --release and build --release --all-features separately. Is this to make sure the default features and all features both build correctly?
I've duplicated it but was just curious whether it was intentional or accidential.
Collaborator
There was a problem hiding this comment.
Right. There is a local-dev feature that we want to verify, but that feature is not enabled for a production build. I have been meaning for the longest time to make those two builds concurrent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
actions/checkoutpermissions: {contents: read}(this is default for push/pull request events)