Format Composio trigger labels#2
Closed
oxoxDev wants to merge 4 commits into
Closed
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Added `formatTriggerLabel` utility to handle slug humanization. - Implemented prefix deduplication (e.g., GOOGLECALENDAR_GOOGLE_CALENDAR -> Google Calendar). - Enforced "GitHub" casing for tokens. - Updated TriggerToggles and ComposeioTriggerHistory to use the formatter. - Updated relevant tests to reflect formatted labels. Co-authored-by: oxoxDev <164490987+oxoxDev@users.noreply.github.com>
oxoxDev
force-pushed
the
format-composio-trigger-labels-13749960330781174990
branch
from
8e99819 to
d6e281e
Compare
…ilter empty tokens (tinyhumansai#1129) CodeRabbit feedback: explicit empty-string overrides were being skipped by the truthy check. Switch to hasOwnProperty so mapped values are always honored. Also filter empty tokens from split() so consecutive underscores (e.g. LINEAR__ISSUE___CREATED) collapse to single spaces. Co-authored-by: oxoxDev <164490987+oxoxDev@users.noreply.github.com>
…inyhumansai#1129) CodeRabbit feedback: prior multi-underscore test only had single underscores. Replaced with LINEAR__ISSUE___CREATED. Also added a test asserting the hasOwnProperty path returns explicit empty-string overrides. Co-authored-by: oxoxDev <164490987+oxoxDev@users.noreply.github.com>
…tinyhumansai#1129) CodeRabbit feedback: when multiple repos share the same trigger slug, the plain 'Enable GitHub Push Event' label was indistinguishable to screen-reader users. Now appends 'for <owner>/<repo>' for github_repo scope. Co-authored-by: oxoxDev <164490987+oxoxDev@users.noreply.github.com>
oxoxDev
added a commit
that referenced
this pull request
May 19, 2026
…ai#1398) rand::random::<u64>() draws from a thread-local PRNG with predictable seeding — adequate for non-adversarial code paths but unsafe for an on-chain order salt where predictability is exploitable by front-runners who observe partial nonce/salt sequences and replay/front-run. Switch to OsRng (re-exported through chacha20poly1305::aead, the same import shape encryption/core.rs already uses), draw 8 fresh bytes from the OS entropy source, and feed those to the existing u64 salt slot. Addresses M3gA-Mind review (must-fix #2). Refs tinyhumansai#1398 (Polymarket trading)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change replaces raw provider enum slugs like
GOOGLECALENDAR_GOOGLE_CALENDAR_EVENT_CREATED_TRIGGERwith formatted, human-readable labels (e.g.,Google Calendar Event Created) across all user-facing UI components.Key improvements:
formatTriggerLabelinapp/src/lib/composio/formatters.ts.aria-labelon toggles.TriggerToggles.tsx:183is now also formatted.Raw slugs are preserved in component state and props to ensure no regressions in enable/disable or signature logic.
PR created automatically by Jules for task 13749960330781174990 started by @oxoxDev