Add Settings coverage (13.2-13.5)#5
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Add WDIO specs for Developer Options, Data Management, Channels, and AI Skills. - Add Vitest unit tests for settings-related Redux slices. - Update test coverage matrix to reflect new coverage status. - Ensure destructive flows (clear app data) include cancel-then-confirm assertions. Closes issue: 969 Co-authored-by: oxoxDev <164490987+oxoxDev@users.noreply.github.com>
oxoxDev
force-pushed
the
fix/settings-coverage-gap-969-3773865147756428290
branch
from
e0ec950 to
b6b2603
Compare
|
Closing — re-signed with oxoxDev's GPG key and re-opened against tinyhumansai/openhuman per repo workflow (cross-repo PR target). |
Understood. Acknowledging that this PR is being closed and re-opened according to the repository's workflow. Stopping work on this branch. |
tinyhumansai#1398) get_json, post_json_raw, and delete_json each carried a ~60-line identical retry loop differing only in HTTP method label and minor response-parsing details. Collapse all three into a single send_with_retry method parameterised by reqwest::Method, optional query params, optional body. ~180 LOC removed; the retry policy, timeout handling, status-class classification, and error-message shape are now consistent across every Polymarket HTTP exit. GET previously parsed via `response.json::<Value>()` and POST/DELETE via `text() + serde_json::from_str`. Unified to the text-then-parse shape so empty bodies normalise to `Value::Null` for all verbs — no behavioural drift for already-passing tests. Addresses M3gA-Mind review (should-fix #5). Refs tinyhumansai#1398 (Polymarket trading)
1 participant
This PR closes the coverage gaps for Settings sections 13.2 through 13.5 as part of the parent epic tinyhumansai#773. It includes 4 new WDIO specs for E2E verification and a new Vitest spec for unit testing the store logic. Destructive flows are isolated and verified with confirmation dialogs.
PR created automatically by Jules for task 3773865147756428290 started by @oxoxDev