Conversation
* occurs in the OxyplotMauiSample when opening the PanModePage
* in order to fix strange crashes when opening PanModePage (on Android and iOS) * $(MauiVersion) seems to resovle to 10.0.1 with .NET SDK 10.0.103
There was a problem hiding this comment.
Pull request overview
Fixes a crash in the MAUI sample app (reported in issue #26) by hardening iOS font loading, and corrects sample app identity/manifest typos while updating the sample’s MAUI package version.
Changes:
- Add a null-guard in iOS
MauiFontLoader.Loadto preventPath.Combinefrom receiving a null filename. - Rename sample app identifiers from
OxyplotMauiSimpletoOxyplotMauiSampleacross platform manifests and the sample.csproj. - Pin the sample app to
Microsoft.Maui.Controls10.0.40.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Source/OxyplotMauiSample/Platforms/Windows/app.manifest | Fix WinUI assembly identity name to match sample app. |
| Source/OxyplotMauiSample/Platforms/Tizen/tizen-manifest.xml | Fix Tizen executable name to match sample app. |
| Source/OxyplotMauiSample/OxyplotMauiSample.csproj | Update app title/id and pin MAUI Controls version for the sample. |
| Source/OxyPlot.Maui.Skia/Platforms/iOS/MauiFontLoader.cs | Prevent crash by handling null from font registrar before filesystem resolution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* and mirror the same behavior on MacCatalyst * as suggested by Copilot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash of the sample app, as reported in issue #26. The first commit contains the fix for the exception from #26, the second commit fixes a typo in the test app and the third commit updates MAUI to the latest version, in order to avoid crashes of the sample app with .NET 10.