Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c10af1f580
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - **OG Collateral Token** → `OG_COLLATERAL` | ||
| - **OG Bond Amount** → `OG_BOND_AMOUNT` | ||
| - **OG Rules (Natural Language)** → `OG_RULES` | ||
| - **OG Challenge Period** → `OG_CHALLENGE_PERIOD` |
There was a problem hiding this comment.
Map challenge period to OG_LIVENESS to avoid silent ignore
The new frontend mapping tells users to wire OG Challenge Period to OG_CHALLENGE_PERIOD, but the deployment script reads OG_LIVENESS (see DeploySafeWithOptimisticGovernor.loadConfig), so any UI that follows this doc will silently ignore the value and deploy with the default 2‑day liveness. This misconfiguration is easy to miss and results in incorrect governance timing for deployments driven by the frontend.
Useful? React with 👍 / 👎.
Motivation
Web Frontendsection toREADME.mdto document a lightweight UI that mirrors the deploy script by describing dependencies, local dev commands, required RPC/default address env vars, form-to-onchain-parameter mappings, and a static-hosting deployment note.Description
README.mdto add aWeb Frontendsection that lists frontend dependencies, local development steps (npm install,npm run dev), required environment variables (e.g.,MAINNET_RPC_URL,SEPOLIA_RPC_URL,SAFE_SINGLETON,OG_MASTER_COPY,MODULE_PROXY_FACTORY), the mapping from UI form fields to deployment parameters (e.g.,Safe Owners→SAFE_OWNERS,OG Rules→OG_RULES), and guidance on static build output (e.g.,dist/orbuild/) and hosting.Testing
Codex Task