fix(cli): reject --json combined with --mermaid#19
Merged
Conversation
`--json` emits a single `{"ok":true,...}` JSON envelope and `--mermaid`
emits a Mermaid diagram. The flag-parsing loop in `internal/cli/cli.go`
set each flag independently, so passing both was accepted: the
downstream code paths then raced for output shape, with whichever the
consumer reached last silently winning. This broke piping and gave
surprising results to anyone who tried `gograph ... --json --mermaid`
or `--mermaid --json`.
After the flag scan, if both are set, print a one-line error to stderr
and exit 1 instead of letting the request through. The error message
names both flags so a user can re-run with the right one.
Owner
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix(cli): reject --json combined with --mermaid
--jsonemits a single{"ok":true,...}JSON envelope and--mermaidemits a Mermaid diagram. The flag-parsing loop in
internal/cli/cli.goset each flag independently, so passing both was accepted: the
downstream code paths then raced for output shape, with whichever the
consumer reached last silently winning. This broke piping and gave
surprising results to anyone who tried
gograph ... --json --mermaidor
--mermaid --json.After the flag scan, if both are set, print a one-line error to stderr
and exit 1 instead of letting the request through. The error message
names both flags so a user can re-run with the right one.