Merged
Conversation
There was a problem hiding this comment.
Pull request overview
依存パッケージ(特に Webpack 周辺)のアップデートに伴う設定追従と、開発用サーバーで HTTPS を使えるようにする変更です。
Changes:
- Webpack 5 向けに
output.library設定へ移行し、env未指定時も動作するように調整 webpack/webpack-cli/webpack-dev-server/workbox-webpack-pluginを更新し、serialize-javascriptをoverridesで固定- example の
webpack-dev-server設定を v5 互換(static/server: 'https')に更新、.gitignoreの対象パス修正
Reviewed changes
Copilot reviewed 3 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| webpack.config.js | Webpack 5 の library 設定形式へ更新、env ガード追加 |
| package.json | Webpack 関連の依存更新、overrides 追加、build コマンド更新 |
| examples/p5-ocr/webpack.dev.js | dev-server v5 互換設定(static、HTTPS)へ更新、Workbox を dev から除去 |
| examples/p5-ocr/dist/main.js.LICENSE.txt | ビルド生成物(LICENSE 抽出ファイル)が追加 |
| dist/p-code.js.LICENSE.txt | ビルド生成物(LICENSE 抽出ファイル)が追加 |
| .gitignore | example の dist 無視パスを修正 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
依存パッケージの更新。Webpackをアップグレードしたので書き方変わってます。
ブラウザ警告出ますがwebpack-dev-serverの自己証明書でhttpsプロトコルが使えるようになっています。
問題なければマージ、その後masterにもマージして、ブランチ名をmainにリネームしたい。