Skip to content
This repository was archived by the owner on Feb 9, 2026. It is now read-only.

Fix for strange devhelp behavior launched from nonroot#3

Merged
p12tic merged 1 commit into
p12tic:masterfrom
Sagrer:master
Mar 25, 2017
Merged

Fix for strange devhelp behavior launched from nonroot#3
p12tic merged 1 commit into
p12tic:masterfrom
Sagrer:master

Conversation

@Sagrer
Copy link
Copy Markdown
Contributor

@Sagrer Sagrer commented Mar 16, 2017

Hi.
I found a strange bug, trying to use this docs with Devhelp on Ubuntu (tested on 2 real computers with Kubuntu and Xubuntu). Seems that webkit2gtk from devhelp for some reason don't want to read html pages with XHTML DOCTYPE when launched from regular user or even from sudo, but works fine when launched from root directly. I can't find a real reason of this due to a very large source code of webkit and my low skills in debugging, so i made this walkaround, just changed cppreference output settings to change DOCTYPE to html. After that this all works for me on all my computers.

More info is here https://bugs.launchpad.net/ubuntu/+source/cppreference-doc/+bug/1668085
Also the same thing was detecded by somebody in archlinux https://aur.archlinux.org/packages/cppreference-devhelp/
PPA with modified packages:
https://launchpad.net/~sagrer/+archive/ubuntu/cppreference-doc

Also i added gbp config to my repository to make gbp using some more easy, changed upstream link to correct commit, added a tag to last upstream and added a branch for autogeneration of patches by gbp pq, may be this all can be added to main repository too, i think this all makes things more easy :).

@p12tic
Copy link
Copy Markdown
Owner

p12tic commented Mar 16, 2017

Hi,

Thanks for bringing this to my knowledge and thanks for the PR! It looks like that the current upstream repository might already have a fix for this issue - the output html files use <!DOCTYPE html>. I'll check this on my side, could you also verify that the issue is gone by downloading this archive, doing make all and copying the devhelp files to correct location (or doing sudo make install)?

I'll fix the bug by doing a new upstream release with updated documentation.

With regards to gbp config, it looks fine, I could merge it if you updated this PR to exclude the file.

@Sagrer
Copy link
Copy Markdown
Contributor Author

Sagrer commented Mar 19, 2017

I checked 20170214 archive and yes, the issue is gone.

With regards to gbp config, it looks fine, I could merge it if you updated this PR to exclude the file.

you mean that you need a PR, which has only this one added file, without any other changes?

@p12tic
Copy link
Copy Markdown
Owner

p12tic commented Mar 22, 2017

you mean that you need a PR, which has only this one added file, without any other changes?

Yes. You don't need to open a new PR - the branch can be rewritten and force-pushed to Github.

@Sagrer
Copy link
Copy Markdown
Contributor Author

Sagrer commented Mar 24, 2017

Reverted the master branch and force-pushed it. PR looks strange but seems that it works :).

@p12tic p12tic merged commit a1d6948 into p12tic:master Mar 25, 2017
@p12tic
Copy link
Copy Markdown
Owner

p12tic commented Mar 25, 2017

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants