Skip to content

Update to latest API specifications#23

Merged
xgp merged 2 commits intop2-inc:mainfrom
ltronky:update-to-latest-api-spec
Mar 30, 2026
Merged

Update to latest API specifications#23
xgp merged 2 commits intop2-inc:mainfrom
ltronky:update-to-latest-api-spec

Conversation

@ltronky
Copy link
Copy Markdown
Contributor

@ltronky ltronky commented Mar 28, 2026

No description provided.

@xgp
Copy link
Copy Markdown
Member

xgp commented Mar 29, 2026

Hi @ltronky. Thanks for updating this. Can you post the code generator steps you used, with the command and version of the OpenAPI generator? I've looked over most of it, and it looks fine, but I want to document how it got built.

@ltronky
Copy link
Copy Markdown
Contributor Author

ltronky commented Mar 29, 2026

Hi @ltronky. Thanks for updating this. Can you post the code generator steps you used, with the command and version of the OpenAPI generator? I've looked over most of it, and it looks fine, but I want to document how it got built.

Hi @xgp, I tried to follow the instructions in the README

At step 3, I've used

docker run --rm --user $(id -u):$(id -g) -v $PWD:/local openapitools/openapi-generator-cli:latest-release generate -i /local/openapi.yaml -g jaxrs-spec -o /local/java-sdk  --additional-properties=groupId=io.phasetwo,artifactId=phasetwo-admin-client,apiPackage=io.phasetwo.client.openapi.api,modelPackage=io.phasetwo.client.openapi.model,useSwaggerAnnotations=false,useBeanValidation=false,useTags=true,interfaceOnly=true,useJakartaEe=true,hideGenerationTimestamp=true

targeting the latest stable version.

At step 4, the first cp has nothing to copy, but I avoided deleting RestResourceRoot.java.
I've deleted everything in src/gen, except this file, and then executed the other 3 cp commands.

About step 5, in my understanding, I've cleaned up the wrong/useless imports, and set the Response return type instead of void, when I thought it was appropriate.
Then I've adapted the files in the main folder to make it compile.


I came to this update chasing a bug on the magic-link project. You can find my other two PRs in phasetwo-docs and in keycloak-magic-link projects.

@xgp xgp merged commit eb8e25a into p2-inc:main Mar 30, 2026
@ltronky ltronky deleted the update-to-latest-api-spec branch March 30, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants