diff/patch: refactor #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ar slots; add test for null-valued collections
…ests and Python API
…tes; tests + Python API
…patch(); expose node_id and trace in Python; adjust CLI and tests
…l PatchTrace; remove JSON roundtrip and ID reconciliation; preserve scalar node IDs on in-place updates
…tore network-based CLI tests; remove dead code
…ead of expect/panic; update tests, CLI, and Python bindings
Improve null handling and diff operations
…kMLValue::Null; add node_id to Null; handle Null in to_json, traversal, and parsing; resolve conflicts
…cting Null directly; handle Null in trace traversal
…or single, list, and mapping inlined cases
…ity coverage; revert CLI offline toggle and run tests with network
…h API takes treat_missing_as_null; CLI flag; Python equals/patch args; tests for equality and no-op semantics; preserve scalar node_ids
…} with defaults; make no-op skipping configurable; wire CLI --ignore-noop/--treat-missing-as-null; update Python patch signature; update tests
Collaborator
Author
|
hello @sneakers-the-rat for me this one is ready to merge ... do you still want to have another look, or shall we merge ? |
Collaborator
Author
|
argh i didn't tag you as a reviewer .. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** NEW PR ** i merged the other one (#6) in main by accident so github autoclosed it and i can't get it to reopen. so i force-pushed to main, and i create this PR with the same contents.
I tried to protect the main branch (should prevent me doing this in the future) but i don't have the rights. @sneakers-the-rat can you ?