Remove .local / Avahi support#15
Open
VijitSingh97 wants to merge 1 commit into
Open
Conversation
Drop mDNS/.local hostname resolution: it only helps on a single LAN segment and silently fails elsewhere. The pool/stack host should be an IP or DNS-resolvable hostname instead. Removes the .local-appending 'smart address handling' and the avahi packages from the dependency install lists (apt/dnf/pacman). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
mDNS/
.localresolution is a LAN-only convenience: it only works when the worker rig and the pool/stack host share a single broadcast domain, and it silently fails (or resolves to the wrong host) on routed networks, VPNs, or anything beyond one subnet. It also pulls in the Avahi daemon as a build/runtime dependency for every install.What changed
rigforge.sh.localto short hostnames. The configuredP2POOL_NODE_HOSTNAMEis now used as-is.avahi-daemon(apt),avahi(dnf), andavahi(pacman) packages from the dependency install lists.README.mdVerification
shellcheck rigforge.shintroduces no new findings (the two pre-existinginfo-level notes on main are unchanged).grep -rin 'avahi\|mdns\|\.local' rigforge.sh README.mdreturns nothing.Closes #14
🤖 Generated with Claude Code