Add editing p2poolv2 config file by R27-pixel · Pull Request #20 · p2poolv2/pdm

R27-pixel · 2026-04-11T08:37:33Z

Open, edit, save config.toml file

Added p2pool_config.rs (adapter for Config)
p2pool_config_view.rs (like BitcoinConfigView) Add editing Bitcoin config file #19

The imported P2poolv2_Config is deeply nested and not suitable for TUI lists.
The adapter flattens it into rows and maps edits back.

Demo

codecov · 2026-04-11T08:39:26Z

Codecov Report

❌ Patch coverage is 88.01809% with 159 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/p2poolv2_config.rs	87.62%	76 Missing ⚠️
src/main.rs	80.71%	59 Missing ⚠️
src/components/p2pool_config_view.rs	95.00%	20 Missing ⚠️
src/app.rs	42.85%	4 Missing ⚠️

📢 Thoughts on this report? Let us know!

Copilot

Pull request overview

Adds support for opening, editing, and saving a p2poolv2 config.toml from the TUI by introducing a “flattened rows” adapter around the deeply-nested p2poolv2_config::Config, plus a dedicated config view and new app actions to commit edits and persist them back to disk.

Changes:

Introduces a p2poolv2_config adapter that flattens Config into editable rows and applies edits back to the nested struct.
Updates the TUI to navigate and edit P2Pool config entries, including sensitive-field masking.
Adds save logic intended to patch the original TOML in-place (preserving comments/formatting) and expands integration tests around P2Pool config flows.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
`src/p2poolv2_config.rs`	New adapter layer (`flatten_config` / `apply_edit`) + schema metadata + unit tests.
`src/components/p2pool_config_view.rs`	Reworks the P2Pool config screen into a list/detail editor with edit mode and masking.
`src/main.rs`	Wires P2Pool config screen input handling, commit/save actions, and TOML patch-based saving + tests.
`src/app.rs`	Adds new `AppAction`s and stores `P2PoolConfigView` in app state.
`src/lib.rs`	Exposes `p2poolv2_config` module publicly.
`Cargo.toml` / `Cargo.lock`	Adds TOML editing + Bitcoin network parsing deps and updates lockfile accordingly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

R27-pixel · 2026-04-18T10:20:42Z

 ratatui = "0.29.0"
 p2poolv2_config = { git = "https://github.com/p2poolv2/p2poolv2", package = "p2poolv2_config" }
+bitcoin = "0.32.5"
+toml = "0.8"


removed the unused toml dependency.

R27-pixel · 2026-04-18T10:48:12Z

+        let panels = Layout::default()
+            .direction(Direction::Horizontal)
+            .constraints([Constraint::Percentage(45), Constraint::Percentage(55)])
+            .split(area);


updated the config view to render warning and save messages so validation errors and save feedback are visible.

R27-pixel · 2026-04-18T11:31:51Z

+        if let Some(table) = doc.get_mut(&section).and_then(|v| v.as_table_mut()) {
+            // Only update keys that already exist in the file to avoid
+            // injecting fields the user intentionally omitted
+            if table.contains_key(key) {
+                table[key] = toml_edit::value(entry.value.clone());
+            }


updated
now instead of always calling toml_edit::value(entry.value.clone()) (which always produces a string), we now call typed_toml_item_like which inspects the existing item's type in the document and parses the new value into that same type.

R27-pixel · 2026-04-18T11:39:34Z

+        // Needs a real sample config — adjust path to your sample
+        if let Ok(cfg) = P2PoolConfig::load("../config.sample.toml") {
+            let mut app = App::new();
+            app.p2pool_config = Some(cfg);
+            // Find port index
+            let entries = flatten_config(app.p2pool_config.as_ref().unwrap());
+            let port_idx = entries.iter().position(|e| e.key == "port").unwrap();
+            handle_action(
+                AppAction::CommitP2PoolEdit(port_idx, "notanumber".to_string()),
+                &mut app,
+            )
+            .unwrap();
+            assert!(app.p2pool_config_view.warning_message.is_some());
+        }


updated
now config is written inline so the test is fully hermetic, expect instead of if let Ok so a parse failure is a real test failure

R27-pixel · 2026-04-18T12:04:47Z

+        if let Ok(cfg) = P2PoolConfig::load(path.to_str().unwrap()) {
+            let mut app = App::new();
+            app.p2pool_config = Some(cfg);
+            app.p2pool_config_view.warning_message = Some("old warning".to_string());
+
+            let entries = flatten_config(app.p2pool_config.as_ref().unwrap());


replaced all if let ok with expect any future breakage in the fixture TOML will cause a expect panic rather than a silent pass.

R27-pixel · 2026-04-18T12:06:44Z

+            // Point at a directory that doesn't exist so writing fails
+            app.p2pool_conf_path = Some(std::path::PathBuf::from("/nonexistent/config.toml"));


R27-pixel · 2026-04-18T12:11:35Z

+    fn apply_edit_unknown_field_hits_fallback_branch() {
+        use super::apply_edit;
+
+        let mut cfg = make_config();
+
+        // Out of bounds → triggers error path


Updated!
refactored the apply_edit slightly to extract the dispatch logic so tests can inject a fake entry directly, and split this into separate tests for index bounds and unknown-field handling.

…ion errors and save feedback are visible

…in the document and parses the new value into that same type.

framicheli · 2026-04-24T06:32:51Z

Pressing "q" while editing a P2PoolV2 config field quits the application. We should add P2PoolConfig here to avoid this behaviour.

let text_input_active = (app.current_screen == CurrentScreen::BitcoinConfig && !app.bitcoin_config_view.sidebar_focused && app.bitcoin_config_view.editing) || (app.current_screen == CurrentScreen::P2PoolConfig && !app.p2pool_config_view.sidebar_focused && app.p2pool_config_view.editing);

framicheli · 2026-04-24T07:06:07Z

+        .map_err(|e| anyhow::anyhow!("Failed to parse P2Pool config TOML: {}", e))?;
+
+    // Walk every flattened entry and patch the matching TOML key
+    for entry in flatten_config(cfg) {


dial_peers field edits are not saved, flatten_config encodes the field as a CSV string like this n.dial_peers.join(","). When at line 551 typed_toml_item_like is called we get the "Unsupported TOML value type for key: {}" because existing is a TOML array and typed_toml_item_like doesn't handle arrays.
We could fix it adding a new if statement to typed_toml_item_like in order to handle arrays: if let Some(arr) = existing.as_array()

framicheli · 2026-04-24T07:46:52Z

+                            }
                        }
                        app.current_screen = CurrentScreen::P2PoolConfig;
                        app.settings.p2pool_conf_path = Some(path.clone());


These lines run even if the config fails to load. On next startup bootstrap_from_settings tries to load this path, fails and prints an eprintln!

Thanks! updated!!

framicheli · 2026-04-24T07:58:53Z

CurrentScreen::P2PoolConfig has its own explicit arm, no need here.

_ => sidebar_nav(key.code, app),

framicheli · 2026-04-24T08:02:09Z

        }
    }

    // Logic to switch between sidebar items


We should add also P2PoolConfig here, like it's done for BitcoinConfig, in order to cleanup messages and editing state when navigating away from it.

Thanks!! Updated !!

R27-pixel marked this pull request as draft April 11, 2026 11:48

R27-pixel force-pushed the settings branch from e22256e to a882af7 Compare April 16, 2026 16:48

R27-pixel marked this pull request as ready for review April 16, 2026 16:50

pool2win requested a review from Copilot April 17, 2026 12:22

Copilot started reviewing on behalf of pool2win April 17, 2026 12:22 View session

Copilot AI reviewed Apr 17, 2026

View reviewed changes

R27-pixel added 7 commits April 23, 2026 10:29

add editing to p2pool config file

8453d92

test: improve test coverage

9dee77e

test: improve test coverage for p2pool_config_view

4bb123d

update the config view to render warning and save messages so validat…

5538578

…ion errors and save feedback are visible

added type_toml_item_like func,it inspects the existing item's type …

873ca05

…in the document and parses the new value into that same type.

tests: improvement

f747eae

Resolve remaining changes after rebase

c9f76a9

R27-pixel force-pushed the settings branch from 04fa6b9 to c9f76a9 Compare April 23, 2026 11:27

Tests: Improve test coverage for main.rs

8ddafa2

framicheli reviewed Apr 24, 2026

View reviewed changes

R27-pixel added 2 commits April 24, 2026 14:12

fix code and address review

31a293e

update p2poolv2_config dependency

7a31316

pool2win merged commit ad1966b into p2poolv2:main Apr 28, 2026
3 checks passed

		// Point at a directory that doesn't exist so writing fails
		app.p2pool_conf_path = Some(std::path::PathBuf::from("/nonexistent/config.toml"));

Conversation

R27-pixel commented Apr 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Open, edit, save config.toml file

Demo

Uh oh!

codecov Bot commented Apr 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

framicheli Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

framicheli Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

R27-pixel commented Apr 11, 2026 •

edited

Loading

codecov Bot commented Apr 11, 2026 •

edited

Loading

framicheli Apr 24, 2026 •

edited

Loading

framicheli Apr 24, 2026 •

edited

Loading