Fixed vpk info sometimes appearing as file-data#360
Merged
ThisAMJ merged 1 commit intop2sr:masterfrom Apr 27, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thought I tested this issue before submitting the vpk-info PR. Might've missted it because I was installing modpacks the new way, or maybe I just wasn't being very thorough. Noticed it when testing the mdp update recently.
Issue
_dir.vpk files installed to dlc folders appear under file-data and vpk-information. That's bad and annoying from mdp's (and verifier's) perspective.
To fix it I've changed it so that file-data ignores _dir.vpk files since the vpk-information is specifically made for them anyway.
Demo-Testing
You'll notice that in the sar-update demo the _dir.vpk file doesn't appear as both a file and a vpk.
demo: 'demos/sar-update.dem'
'Betsruner' on sp_a2_bridge_the_gap - 60.00 TPS - 758 ticks
events:
[ 0] [SAR] recorded at 2026/04/24 00:12:10 UTC
[ 0] [SAR] VPK "c:/program files (x86)/steam/steamapps/common/portal 2/portal2_dlc3/pak01_dir.vpk" has checksum 12D77D0E
"materials/models/weapons/v_models/v_portalgun/v_portalgun.vtf" has checksum E5B5DA5D
demo v2 checksum FAIL
demo: 'demos/sar1-15.dem'
'Betsruner' on sp_a2_bridge_the_gap - 60.00 TPS - 1148 ticks
events:
[ 0] [SAR] recorded at 2026/04/23 23:52:03 UTC
[ 0] [SAR] file "c:/program files (x86)/steam/steamapps/common/portal 2/portal2_dlc3/pak01_dir.vpk" has checksum 12D77D0E
[ 0] [SAR] VPK "c:/program files (x86)/steam/steamapps/common/portal 2/portal2_dlc3/pak01_dir.vpk" has checksum 12D77D0E
"materials/models/weapons/v_models/v_portalgun/v_portalgun.vtf" has checksum E5B5DA5D