Conversation
eabe31b to
e02fb0b
Compare
|
CI failure is an unexpected checksum when pulling some dependency: |
|
I discovered that if I start relying on a VERSION file, we'd have two sources of truth. E.g. bmv2 uses a script to read that file inside configure.ac. I think I'll just copy what bmv2 does there. Still need to check if there are more such cases of duplication. |
Can you elaborate? At least for BMv2 we should get rid of autotools soon. |
|
Could you also add a form of this? https://github.com/p4lang/behavioral-model/blob/main/.github/release.yml The automated release notes are useful |
|
Whoa, I didn't know about .github/release.yml. I'll add it. I was uncertain about configure.ac. I just noticed, mechanically, that it does refer to a version number. Seems safer to keep it up to date, even if autotools is going to get the boot. Unless you think I should just remove the file already? |
Sounds good to me |
de3176d to
577794f
Compare
Signed-off-by: Bryan Richter <b@chreekat.net>
This is modeled after the machinery in behavioral-model and ptf, with some internal cleanups. Signed-off-by: Bryan Richter <b@chreekat.net>
Modeled on the configuration in behavioral-model. Signed-off-by: Bryan Richter <b@chreekat.net>
577794f to
e0604a9
Compare
|
I decided to simply not touch configure.ac. Let's remove all the autoconf stuff in a dedicated PR. For release.yml, I copied the one over from behavioral-model, then removed stuff that didn't look relevant to PI. NB: The labels don't exist yet in this repo! |
This is modeled after the machinery in behavioral-model and ptf, with some internal cleanups.
Tbh I'm not sure which repos it's appropriate to have automatic releases for? Is PI appropriate? :) Are there more I should do?