Revert recent switch.py changes#688
Merged
jafingerhut merged 33 commits intop4lang:masterfrom May 13, 2025
Merged
Conversation
This may help avoid new users being confused that they must follow those instructions. Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>
Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>
They cause Python exceptions to be raised when initializing other exercises, e.g. basic and ecn at least. Signed-off-by: Andy Fingerhut <andy_fingerhut@alum.wustl.edu>
Collaborator
Author
|
@Dscano Instead of reverting all of the changes you made in this recent PR: #684 I am only reverting the changes made to file utils/p4runtime_lib/switch.py, since those are the only changes that seem to affect the behavior of running other exercises. Unfortunately this probably breaks some or all of the current functionality of the flowcache exercise -- I have not checked that. Hopefully we can find similar but different changes to switch.py that avoid raising exceptions for existing exercises, yet enable flowcache to work as desired. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.