misc improvements (use std::move, use const&, etc)#170
Merged
paceholder merged 1 commit intopaceholder:masterfrom May 11, 2018
Merged
misc improvements (use std::move, use const&, etc)#170paceholder merged 1 commit intopaceholder:masterfrom
paceholder merged 1 commit intopaceholder:masterfrom
Conversation
Owner
|
Looks good! Regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some other things I noticed:
ConnectionGraphicsObject.cpp:172
It might be better to make this a
dynamic_cast(or Qt has an equivalent IIRC), which would make it an error if it was wrong, rather than silently failing.NodeGeometry.cpp
The
_entryWidthmember is never set, but it's also never used, asentryBoundingRect()is never called