Skip to content

misc improvements (use std::move, use const&, etc)#170

Merged
paceholder merged 1 commit intopaceholder:masterfrom
Quincunx271:misc-improvements
May 11, 2018
Merged

misc improvements (use std::move, use const&, etc)#170
paceholder merged 1 commit intopaceholder:masterfrom
Quincunx271:misc-improvements

Conversation

@Quincunx271
Copy link
Copy Markdown
Contributor

Some other things I noticed:

  • ConnectionGraphicsObject.cpp:172

     auto view = static_cast<QGraphicsView*>(event->widget());

    It might be better to make this a dynamic_cast (or Qt has an equivalent IIRC), which would make it an error if it was wrong, rather than silently failing.

  • NodeGeometry.cpp
    The _entryWidth member is never set, but it's also never used, as entryBoundingRect() is never called

@paceholder
Copy link
Copy Markdown
Owner

paceholder commented May 11, 2018

Looks good!

Regards,
Dmitry

@paceholder paceholder merged commit 5f3d843 into paceholder:master May 11, 2018
@Quincunx271 Quincunx271 deleted the misc-improvements branch May 11, 2018 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants