Fixed text-labelling issue Planned Charge when Friendly-text set True#18
Merged
pacemaker82 merged 1 commit intopacemaker82:mainfrom Apr 23, 2024
Merged
Fixed text-labelling issue Planned Charge when Friendly-text set True#18pacemaker82 merged 1 commit intopacemaker82:mainfrom
pacemaker82 merged 1 commit intopacemaker82:mainfrom
Conversation
Previous behaviour: when friendlyText = "NoCharge": line 405 replaces this with 'Charge to "Limit"' and then line 406 replaces the word "Charge" with "Planned Charge" Resulting in friendlyText = Planned Charge to "Limit" - which seemed not the desired result
Owner
|
good catch - thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Love the card - spotted something that might be intended behaviour, but that felt off... so here's a PR for a fix
Previous behaviour:
when friendlyText = "NoCharge":
line 405 replaces this with 'Charge to "Limit"' and then line 406 replaces the word "Charge" with "Planned Charge"
Resulting in friendlyText = Planned Charge to "Limit" - which seemed not the desired result