Skip to content

Fixes #22#23

Merged
dmlb2000 merged 2 commits intopacifica:masterfrom
kauberry:issue-22-more_production_fixes
Apr 28, 2017
Merged

Fixes #22#23
dmlb2000 merged 2 commits intopacifica:masterfrom
kauberry:issue-22-more_production_fixes

Conversation

@kauberry
Copy link
Contributor

@kauberry kauberry commented Apr 28, 2017 •
edited
Loading

Minor fixes to clear up some production rollout issues

Description

  • Squashes duplicate transaction entries in the returned summary data
  • Provides an additional named endpoint for userinfo searches to better fit in with proposalinfo and instrumentinfo. (They had 'by_instrument_id' and 'by_proposal_id', but userinfo just had 'by_id'. Now it has a 'by_user_id' option as well)
  • Better checking for the time_basis type to allow for normalization of the actually set type

Issues Resolved

#22

Check List

kauberry-pnnl and others added 2 commits April 28, 2017 02:09
@kauberry-pnnl
Fixes pacifica#22
144b779 
Minor fixes to clear up some production rollout issues
@kauberry
Merge branch 'master' into issue-22-more_production_fixes
a7c37c2
dmlb2000
dmlb2000 approved these changes Apr 28, 2017
View reviewed changes
Copy link
Member

@dmlb2000 dmlb2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks okay for me.

@dmlb2000 dmlb2000 merged commit 98fa07c into pacifica:master Apr 28, 2017
@kauberry kauberry deleted the issue-22-more_production_fixes branch May 18, 2017 18:55
@bonilla-pnnl bonilla-pnnl mentioned this pull request Jan 16, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmlb2000 dmlb2000 dmlb2000 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kauberry @dmlb2000 @kauberry-pnnl