Skip to content

Conversation

@markborkum
Copy link
Contributor

Description

n/a

Issues Resolved

n/a

Check List

  • All tests pass.
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable

markborkum and others added 30 commits September 16, 2018 16:49
Signed-off-by: David Brown <dmlb2000@gmail.com>
Flake8 warned that the operator callables were globals. In a previous commit, the operator callables were refactored into method-locals in the operator's constructor. This is sufficient to resolve the flake8 warnings, but introduces a bug: since callables are created per instance, they have different memory locations, and hence, are not compatible with the `Node`-level definition of `__eq__`, which naively compares each `__dict__` of each operand. The fix is to refactor the operator callables into static methods.
Signed-off-by: David Brown <dmlb2000@gmail.com>
Signed-off-by: David Brown <dmlb2000@gmail.com>
In previous implementations of JSONPath, the current value is implicitly cast to array or object if the next node is an array index subscript or object index subscript. This introduces ambiguity: "is the index subscript referring to the current value, or a child value of the current value?" The solution is to use the wildcard "*" to refer to the child values explicitly.
Signed-off-by: David Brown <dmlb2000@gmail.com>
Signed-off-by: David Brown <dmlb2000@gmail.com>
Aim for feature parity with equivalent in Python programming language
@markborkum
Copy link
Contributor Author

Commit 5f4f817 is subsumed by pull #14.

@markborkum markborkum closed this Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants