-
Notifications
You must be signed in to change notification settings - Fork 13
Support contains operator #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kuldeepluvani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
|
Can you give some examples in other places where Also looks like you need some testing to cover the new code you created. Thoughts? |
|
I'm currently trying to create some unit tests, it took me a little bit to get the antlr4 code generated, and now seeing what I might of missed to get past the: And let me look more into the the ~= vs contains, there's a good chance you're right, I was mainly just trying to figure out how to add to the code, before finalizing (hope it's not too distracting for you), thanks for the library! I just checked and yes the ~ is for regex, I'll flip to: and maybe see if I can easily add regex or not. |
feb4811 to
1f468d0
Compare
|
@dmlb2000 I think this should cover the cases for contains, let me know if you'd like more tests? Also it would be pretty easy to add the |
|
@dmlb2000 I've also started adding the I'll create a PR against this repo later but if you want to look at the possible changes I have a working branch on my fork if you have any advice: KyleJamesWalker#1 |
|
@KyleJamesWalker I agree it will be a challenge to get the regex to pass through antlr to apply the standard regex library. However, if you feel you have the ability/time to do that I can review and help a little. Feel free to submit a new bug with the regex addition and make a merge request. |
|
@dmlb2000 How do you feel about this PR. Once this is merged, I can try and work on some more ideas on how to pass the flag to the regex matching. I at least have a small start so far with the 2nd PR. |
dmlb2000
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution. Looks good to me!
Description
Add the contains operator.
Note: This hasn't been tested yet, I wanted to see about getting some feedback before proceeding with this PR.
Issues Resolved
#61
Check List