Skip to content

feat(tests): Additional parametrization of tests#202

Merged
jeremylong merged 2 commits intopackage-url:masterfrom
ppkarwasz:feature/junit-refactor
Mar 19, 2025
Merged

feat(tests): Additional parametrization of tests#202
jeremylong merged 2 commits intopackage-url:masterfrom
ppkarwasz:feature/junit-refactor

Conversation

@ppkarwasz
Copy link
Copy Markdown
Contributor

Replaces many test cases with parameterized tests that take their data from JSON files.

Comment thread src/test/java/com/github/packageurl/JsonTestData.java Outdated
Comment thread src/test/java/com/github/packageurl/PackageURLBuilderTest.java Outdated
@ppkarwasz ppkarwasz marked this pull request as draft March 17, 2025 11:16
@ppkarwasz
Copy link
Copy Markdown
Contributor Author

I am marking this PR as draft to adapt it to #206.

@ppkarwasz ppkarwasz changed the title Replace test cases with parameterized tests feat(tests): Additional parametrization of tests Mar 17, 2025
Replaces many test cases with parameterized tests that take their data from JSON files.
@ppkarwasz ppkarwasz force-pushed the feature/junit-refactor branch from 69bae2e to 021be6d Compare March 17, 2025 20:59
@ppkarwasz ppkarwasz marked this pull request as ready for review March 17, 2025 20:59
@ppkarwasz
Copy link
Copy Markdown
Contributor Author

I merged the differences with #206, so this is ready for review.

Copy link
Copy Markdown
Collaborator

@jeremylong jeremylong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremylong jeremylong merged commit 684c305 into package-url:master Mar 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants