Mark outdated, st2-only and st3-only, packages#232
Merged
Conversation
Collaborator
Author
Comment on lines
+128
to
+130
| const doesNotSupportNewestSublime = releases.every((release) => { | ||
| return util.parseSublimeTextMax(release.sublime_text) < 4000 | ||
| }) |
Contributor
There was a problem hiding this comment.
Do you want to change the magic search penalty to use doesNotSupportNewestSublime instead of supportsModernSublime?
Collaborator
Author
There was a problem hiding this comment.
Only <=3000 gets a downvote because the standard "*" (most packages really) means just >=3000. IIRC more than 4000 packages have "*".
Contributor
|
I agree with the top two posts, though I think the top-right labeling should use the "archive box" of R.I.P., although maybe a less intense color. Seems reasonable to ship for now, though. |
e84a435 to
7a759fd
Compare
Collaborator
Author
|
Actually, one could argue to just invent synthetic RIP and MIA labels as well, then we can search for them and have a very clean top-right corner. 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

We create two synthetic labels "st3" and "<st3", style them a bit different and get a lot for free.