Add an alternative approach to create a migration package #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@IgorBenko not quite sure what you mean. The tar command with --transform renames the folders to what we expect. The import command then extracts those files onto the filesystem before uploading them to the desired storage. |
glaubinix
approved these changes
Nov 27, 2024
Member
glaubinix
left a comment
glaubinix
left a comment
There was a problem hiding this comment.
Looks good. Feel free to merge, if the previous comment clears up everything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing the migration tar archive we expect there to be two folders:
distandartifactThat's why the
composerfolder must be renamed todistandartifactsfolder toartifact.@glaubinix the only thing I don't quite understand is that the
SelfHostedStorageMigrationCommandis also expecting these two folders on the source system - at least when using FlySystem/S3. I presume there is some logic somewhere that maps composer and artifacts folders in local FS accordingly, but couldn't find that. Please let me know if I'm missing something here.