Skip to content

Add prep_sources MCP tool and Kerberize download_sources MCP tool#386

Merged
TomasTomecek merged 1 commit intopackit:mainfrom
antbob:5_rhpkg_mcp
Mar 16, 2026
Merged

Add prep_sources MCP tool and Kerberize download_sources MCP tool#386
TomasTomecek merged 1 commit intopackit:mainfrom
antbob:5_rhpkg_mcp

Conversation

@antbob
Copy link
Copy Markdown
Contributor

@antbob antbob commented Mar 9, 2026

The rhpkg tool requires authentication even for basic operations like downloading sources and package prep. This commit adds a new prep_sources MCP tool and updates download_sources MCP tool to use Kerberos. If Kerberos auth is unavailable or fails the logic is to log a warning and continue so this should not change the existing behavior and should work for both rhpkg and centpkg tools.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new prep_sources MCP tool and adds Kerberos authentication support to the download_sources tool. The changes include refactoring command creation into a helper function and adding a helper to attempt Kerberos initialization while gracefully handling failures. The implementation looks good, and the new functionality is covered by unit tests. My main feedback is to improve error handling by capturing and reporting the stdout/stderr from subprocess calls, which will significantly aid in debugging failures.

Note: Security Review did not run due to the size of the PR.

Comment thread mcp_server/lookaside_tools.py
Copy link
Copy Markdown
Member

@TomasTomecek TomasTomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomasTomecek TomasTomecek merged commit b728afc into packit:main Mar 16, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants