Account for circular expansion of tags

[nforro]

RELEASE NOTES BEGIN

Fixed an issue where the value of a tag could have been incorrectly expanded if the spec file contained a macro definition shadowing the tag name, e.g.:

%global release 12
%global release_string %{release}%{?dist}

Release: %{release_string}

In this case, with dist being .fc44, Specfile.expanded_release returned 12.fc44.fc44 instead of 12.fc44.

RELEASE NOTES END

[gemini-code-assist]

Code Review

This pull request addresses circular macro expansion issues in RPM tags by manually deleting tag macros before expansion and invalidating the parser cache. The review feedback highlights that the current implementation in specfile.py is ineffective because the use of extra_macros triggers a re-parse that restores the deleted macros. Key recommendations include refactoring the duplicated logic into a helper method to improve maintainability, ensuring consistent cache invalidation, using %{nil} for efficient context loading, and expanding test coverage to verify all affected paths.

[centosinfra-prod-github-app]

Build succeeded.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/86864f2cef8544eaadf1ad7521fc3089

✔️ pre-commit SUCCESS in 2m 07s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 50s
✔️ specfile-tests-pip-deps SUCCESS in 1m 49s

[nforro]

/gemini review

[gemini-code-assist]

Code Review

This pull request addresses circular macro expansion issues by manually managing the RPM macro stack and invalidating the parser cache. Review feedback suggests ensuring that the parser cache is consistently invalidated whenever the macro stack is modified, specifically in add_changelog_entry and expanded_release. There is also a concern regarding the performance impact of frequent cache invalidations, which may lead to O(N^2) complexity when processing multiple tags.

[centosinfra-prod-github-app]

Build succeeded.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/617b87cf0b704a7e801b541b7b4d3ec9

✔️ pre-commit SUCCESS in 2m 01s
✔️ specfile-tests-rpm-deps SUCCESS in 1m 52s
✔️ specfile-tests-pip-deps SUCCESS in 1m 46s

[centosinfra-prod-github-app]

Build succeeded (gate pipeline).
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/3e5bf9c8dfcd42a29aca25092cbb743c

✔️ pre-commit SUCCESS in 2m 05s