-
Notifications
You must be signed in to change notification settings - Fork 1
Add mass mail functionality #16
Conversation
5ef75e1 to
9d87012
Compare
|
What is the context of the Pull Request? (which problem does it solve? who requested this feature?) The support form is a great idea! We should (later) add some text with more ways to enter in contact :
Mass E-Mail: As-is I see a couple of issues:
I think that all those issues would be solved, by simply giving an export of the participants:
|
I've added a description to the PR.
Good points! Guess I'll add a hint to our GitHub page right away.
I'd do both, offer data export in various formats and this form for convenience.
I can add this information to the form if you want. But the problem whether there is an email address or not does not really depend on whether we have a form to send emails to the participants, right? Even if you export the data, missing email addresses will still be missing. I'd thus strongly encourage people to enter email addresses when registering participants (e.g. for information sent to participants from camp staff).
I've seen this in various other tools, for example our party staff management tool at uni, and there have not been any problems of abuse. I think we can trust people. Besides, every mail server keeps a log of sent emails. So we will know who did what ;)
This is a valid point. We should prevent this from happening (setting up everything as compliant as possible, or using a commercial provider like Google G suite or Office 365 Exchange Online as is the case with dpsg1300.de).
People should export the email addresses in this case. However, I'm thinking about providing some formatting features like a Markdown editor.
Yes, and this is okay I think. Besides, I'm also thinking about offering some personalization tags like
Well, as I have seen this feature in use before, I do not share most of your concerns. The only real concern I see is preventing the mail server from getting blacklisted. But this problem exists independently of this feature (ok, the server is more likely to get blacklisted if we send out more emails). Nevertheless, since we want to send out emails anyway (e.g. when creating new accounts, to reset passwords, ...) we will have to deal with this issue one way or another. Either by being as compliant as possible or using a commercial product as our district is doing. |
|
There are some conflicts (due to the merge of the NaMi lookup).
👍
Ok, lets do it in an other PR
A simple textual warning should be enough (like "only participant with an email will get your message").
I think it would be nice to add a form field with this value (prefilled with the user email). It communicates that the people will be able to reply to the mass email and it lets the user change this reply email (if someone else is expected to handle the complaints for instance).
Maybe another textual warning to the user would be good:
I think we should keep this simple and only support plain text (and encourage the users to use the export for fancier emails). I find the It would probably be better to split it into 2 choices:
This way it is possible to send an email to:
And it removes the strange combination currently possible:
|
👌
Sounds good.
Ok, that's fine for me.
I think adding Markdown support wouldn't be that much work using Django MarkdownX (which looks quite fancy). But yes, this is just a shenanigan :)
Ok, I'll do it this way. Thanks for your feedback! |
b406d58 to
460fb03
Compare
oliverpool
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good!
I have some nitpicks, but actually this is very closed to getting merged 👍 !
|
I've addressed all of your comments. Thanks for your effort! |
oliverpool
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor cleanups and we are good to go!
5e24f7e to
23aab0e
Compare
oliverpool
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
This PR adds functionality to send emails to participants by the respective troop managers (might be reused for people in charge of the age sections) and support requests to a support contact.